fix (olHelpers.js): update wrapX default setting...#331
Merged
juristr merged 1 commit intotombatossals:masterfrom Nov 3, 2016
Merged
fix (olHelpers.js): update wrapX default setting...#331juristr merged 1 commit intotombatossals:masterfrom
juristr merged 1 commit intotombatossals:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original implementation completely missed the fact that the
||default treats false the same as all 'falsey' values (meaning a value of false is the same as no value), making it impossible to turn off wrapX by setting it to false.~ as reported by @thmitchell in a comment on #318